Fix crash in addMedia on Android 28 and below #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, merge. I need it! @amanjeetsingh150 |
|
Hey folks, this would go in 1.40.0 version (next release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I fixed an issue where the addMedia function was crashing on Android 28 and below. The crash was caused by the lack of declaration and permission for WRITE_EXTERNAL_STORAGE, which is required on these Android versions.
To resolve this, I added the WRITE_EXTERNAL_STORAGE permission declaration and implemented a process to grant the permission using adb shell pm. With these changes, the crash in addMedia on Android 28 and below has been resolved.
Testing
I have confirmed the success of running maestro test on emulators for Android versions 24 to 28.
Issues fixed
addMediacauses crash on Android API 28 #1821